Add verify stage #60
Add verify stage #60
Conversation
|
It's been sometime, so just wanted to see if it is still relevant. |
|
@cla-bot[bot] check |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436.
|
|
The cla-bot has been summoned, and re-checked this pull request! |
|
I'm running into a similar issue with docker tests. It would be useful to have this functionality |
|
@nab0310 Really sorry for getting to this so late, I think this enhancement will be useful, though still in draft (it seems like the exception is always thrown in verify stage?), would you mind to sign the CLA? Thanks. |
| throw new MojoExecutionException("There are test failures"); | ||
| } else { | ||
| bufferedReader.close(); | ||
| throw new MojoExecutionException("File has invalid content"); |
There was a problem hiding this comment.
@nab0310 It seems like we'll always fail in this verify stage, is it intended?
|
@cla-bot[bot] check |
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: nb051436.
|
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Hi @nab0310 , we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
This Pull Request is an extension of #59, adding a verify stage would help people who use docker to be able to use the scalatest-maven-plugin because it allows the post-integration test to run.
This is just a rough outline of what I think could be done. Obviously the file writing system is very crude but it was just my first draft. The Surefire plugin features a
FailsafeSummaryXmlUtilsclass that provides utilities for file writing and reading that would provide a good solution to this problem.